Skip to content

Commit

Permalink
test: Upgrade the version of Presto we compare fuzzers in CI against …
Browse files Browse the repository at this point in the history
…to 0.290 (facebookincubator#12096)

Summary:
Pull Request resolved: facebookincubator#12096

We currently run Aggregation, Window, and Writer fuzzers comparing against Presto in CI jobs.
They run Presto at version 0.288. There are known compatibility issues with this older version,
e.g. set_agg and set_union are disabled in AggregationFuzzer because of this.

0.290 appears to be the latest release from Presto and addresses these (we should be able to
enable set_agg and set_union after this).

I ran the Aggregation, Window, and Writer fuzzers against this version of Presto for an hour and
didn't see issues.  We also already run AggregationFuzzer against Presto trunk (or close to it)
for every PR internally.

Reviewed By: kgpai

Differential Revision: D68280837

fbshipit-source-id: 74746306d5065d582dc822e5df3cc98e0bc441a0
  • Loading branch information
Kevin Wilfong authored and facebook-github-bot committed Jan 16, 2025
1 parent 8519fad commit 4ad5a8a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
tags: "ghcr.io/facebookincubator/velox-dev:adapters"
- name: Presto Java
file: "scripts/prestojava-container.dockerfile"
args: "PRESTO_VERSION=0.288"
args: "PRESTO_VERSION=0.290"
tags: "ghcr.io/facebookincubator/velox-dev:presto-java"
- name: Spark server
file: "scripts/spark-container.dockerfile"
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ services:
image: ghcr.io/facebookincubator/velox-dev:presto-java
build:
args:
- PRESTO_VERSION=0.288
- PRESTO_VERSION=0.290
context: .
dockerfile: scripts/prestojava-container.dockerfile
environment:
Expand Down
2 changes: 1 addition & 1 deletion scripts/prestojava-container.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#
FROM ghcr.io/facebookincubator/velox-dev:centos9

ARG PRESTO_VERSION=0.288
ARG PRESTO_VERSION=0.290

ADD scripts /velox/scripts/
RUN wget https://repo1.maven.org/maven2/com/facebook/presto/presto-server/${PRESTO_VERSION}/presto-server-${PRESTO_VERSION}.tar.gz
Expand Down

0 comments on commit 4ad5a8a

Please sign in to comment.