Skip to content

Commit

Permalink
Fix internal build of velox_expression_fuzzer_test (facebookincubator…
Browse files Browse the repository at this point in the history
…#11044)

Summary:
Pull Request resolved: facebookincubator#11044

A previous change happened to break the internal build of expression_fuzzer_test, but the
broken build was not caught at diff-time internally because the expression_fuzzer_test
target was disabled. This target is useful for debugging. This diff fixes the broken build.
Plus, since we only want expression_fuzzer_test to be built but not run at diff time, this diff
changes the target type to cpp_binary and removes the GTest logic that was required to run
it as cpp_unittest before.

Reviewed By: kevinwilfong, kgpai

Differential Revision: D63042420

fbshipit-source-id: 5ac95c5d0692803a0e95039c0954b97f4fccda58
  • Loading branch information
kagamiori authored and facebook-github-bot committed Sep 20, 2024
1 parent 9851a4e commit 8c2fa20
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions velox/expression/fuzzer/ExpressionFuzzerTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

#include <folly/init/Init.h>
#include <gtest/gtest.h>
#include <unordered_set>

#include "velox/expression/fuzzer/ArgGenerator.h"
Expand All @@ -41,8 +40,6 @@ using facebook::velox::fuzzer::FuzzerRunner;
int main(int argc, char** argv) {
facebook::velox::functions::prestosql::registerAllScalarFunctions();

::testing::InitGoogleTest(&argc, argv);

// Calls common init functions in the necessary order, initializing
// singletons, installing proper signal handlers for better debugging
// experience, and initialize glog and gflags.
Expand Down Expand Up @@ -96,5 +93,5 @@ int main(int argc, char** argv) {
{"mod", std::make_shared<ModulusArgGenerator>()},
{"truncate", std::make_shared<TruncateArgGenerator>()}};

return FuzzerRunner::run(initialSeed, skipFunctions, {{}}, argGenerators);
FuzzerRunner::runFromGtest(initialSeed, skipFunctions, {{}}, argGenerators);
}

0 comments on commit 8c2fa20

Please sign in to comment.