Use Velox filesystem in SSD Cache

zacw7 · Jul 17, 2024 · c7f734e · c7f734e
1 parent 5eac2f4
commit c7f734e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/velox/common/caching/SsdFile.cpp b/velox/common/caching/SsdFile.cpp
@@ -160,7 +160,9 @@ SsdFile::SsdFile(const Config& config)
   if (disableFileCow_) {
     disableCow(fd_);
   }
+  auto fs = filesystems::getFileSystem(path_, nullptr);
 
+  writeFile_ = std::make_unique<LocalWriteFile>(fd_)
   readFile_ = std::make_unique<LocalReadFile>(fd_);
   const uint64_t size = lseek(fd_, 0, SEEK_END);
   numRegions_ = std::min<int32_t>(size / kRegionSize, maxRegions_);

diff --git a/velox/common/caching/SsdFile.h b/velox/common/caching/SsdFile.h
@@ -552,14 +552,17 @@ class SsdFile {
   folly::F14FastMap<FileCacheKey, SsdRun> entries_;
 
   // File descriptor. 0 (stdin) means file not open.
-  int32_t fd_{0};
+//  int32_t fd_{0};
 
   // Size of the backing file in bytes. Must be multiple of kRegionSize.
   uint64_t fileSize_{0};
 
   // ReadFile made from 'fd_'.
   std::unique_ptr<ReadFile> readFile_;
 
+  // WriteFile made from 'fd_'.
+  std::unique_ptr<WriteFile> writeFile_;
+
   // Counters.
   SsdCacheStats stats_;