Adding Windows Services, Registry Core Ext from PT Run #120
Conversation
|
This PR includes first passes for both the Windows Services Plugin & the Windows Registry Plugin |
There was a problem hiding this comment.
okay I reviewed the first two commits - services and registry
- I didn't look too hard at the implementation bits that are clearly straight outta PT run. I assume that code's already fine.
- I left a bunch of notes on linking bare
TODOs - we're in the real game now (not just hackathon), so we should have TODO's in the code reference an actual work item tracking that TODO. Otherwise we just lose them. In terminal we've usedTODO GH #xyz: <comment>to help keep track of the issue that's tracking that TODO - I don't know about the resources thing so clint halp pls
- I'm blocking on this
- we probably want to actually implement the copy thing now
- i'm soft-blocking on this
- revert the settings search one and the commit after that, and file a stacked PR for settings search 😜
src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.WindowsServices/WindowsServicesCommandsProvider.cs
Outdated
Show resolved
Hide resolved
src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.WindowsServices/Properties/Resources.resx
Show resolved
Hide resolved
| @@ -0,0 +1,333 @@ | |||
| //------------------------------------------------------------------------------ | |||
There was a problem hiding this comment.
@crutkas I need a C# adult - this looks like the kind of file that should be .gitignored?
|
|
||
| public override ISection[] GetItems(string query) | ||
| { | ||
| ListItem[] items = ServiceHelper.Search(query).ToArray(); |
There was a problem hiding this comment.
📝 we could totally cache this result in the future, but good enough for v1
There was a problem hiding this comment.
Hmmmmm good point - let's just do it? It's probably best practice and we can use that as a sample down the line?
HOW should we do it the BEST way (best being best for now that is reasonable, but does some caching)
src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.WindowsServices/Helpers/ServiceHelper.cs
Outdated
Show resolved
Hide resolved
src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.Registry/Commands/OpenKeyInEditorCommand.cs
Outdated
Show resolved
Hide resolved
src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.Registry/Commands/CopyValueNameCommand.cs
Outdated
Show resolved
Hide resolved
src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.Registry/Commands/CopyValueDataCommand.cs
Outdated
Show resolved
Hide resolved
src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.Registry/Commands/OpenKeyInEditorCommand.cs
Outdated
Show resolved
Hide resolved
src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.Registry/Commands/CopyValueNameCommand.cs
Outdated
Show resolved
Hide resolved
joadoumie
force-pushed
the
joadoumie/windows-services
branch
from
e927e7d to
e5c95ee
Compare
zadjii-msft
changed the title
There was a problem hiding this comment.
@crutkas are these Resources.Designer.cs files supposed to be checked in?
src/modules/cmdpal/Exts/Microsoft.CmdPal.Ext.Registry/Properties/Resources.Designer.cs
Just wanna make sure. Otherwise, this LGTM
| private static bool TryToCopyToClipBoard(in string text) | ||
| { | ||
| // TODO: Have this actually use the clipboard helper | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Indeed. Good catch. thank you. I DONT know how this is still in here tbh.
|
Yes the are included |
|
Ref to #84 |
First pass at adding the equivalent functionality of Windows Services from PT Run.