Repository navigation
Conversation
security -i treats a backslash as an escape inside single quotes, so a POSIX quote stores a\b as ab and rejects a single quote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setbuilds itssecurity -iline withshellescape.Quote. That wrapper is for a POSIX shell.security -iis not one: a backslash takes the next byte literally, including inside single quotes.A service
a\bis stored asab.Setreturns success, and the matchingGetreturns not found. A single quote produces a line the parser rejects with exit 2.Each value is now wrapped in double quotes, with backslash and double quote escaped. On a throwaway keychain,
'a\b'is stored asaband"a\\b"is stored asa\b. A single quote, a double quote, a space, and an empty value round-trip. The POSIX form'a'"'"'b'still exits 2.go test -count=1 .passed. Pointing the quoter back atshellescape.QuotefailsTestSecurityInteractiveQuote.The length check in #156 still calls
shellescape.Quoteon this same line. That call needs this quoter when the two changes meet.Fixes #154