include external traffic policy comparison into service diffing #2956
+67
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
sdudoladov,
Jan-M,
jopadi,
idanovinda,
hughcapet and
macedigital
as code owners
hughcapet
approved these changes
Sep 23, 2025
|
👍 |
github-project-automation
bot
moved this from Waiting for review
to Done
in Postgres Operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are using external load balancers for many of your database clusters chances are you're running short on IPs at some point when using the default service external traffic policy
Cluster. WithClusterthe ELB can send traffic to any node and from there iptables forward rules decide on the "right" instance. WithLocaliptables forwards are not needed because the ELB only sees valid instances directly. We've been supporting configuring the external traffic policy for services for quite some time (#1136), but forgot to also diff on it.The added unit tests also cover the recently added selector diff from #2955.