feat(protocol-contracts): return release time on calls to requestRedeem
#1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 CI InsightsHere's what we observed from your CI run for f6a6488. 🟢 All jobs passed!But CI Insights is watching 👀 |
jatZama
reviewed
Dec 19, 2025
| assert(releaseTime >= lastReleaseTime); // should never happen | ||
| $._redeemRequests[controller].push(releaseTime, controllerSharesRedeemed + shares); | ||
|
|
||
| emit RedeemRequest(controller, ownerRedeem, 0, msg.sender, shares, releaseTime); |
Member
There was a problem hiding this comment.
Just realized this now, but we no longer need the 3rd argument here, which is always 0, in the RedeemRequest event, initially it was only here because we tried to adhere to the ERC7540 (async vaults), but since we dont follow this ERC anyways, especially now that we added the releaseTime in the event, I think we could remove it... wdyt?
Member
There was a problem hiding this comment.
But if we do this, we will probably need to update the front-end app as well, so it might be too late actually.
Contributor
There was a problem hiding this comment.
we will update this in #1681 + consider the change in the frontend once it is merged yes !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a return type of
uint48to therequestRedeemfunction. The return value is the timestamp at which the redemption request is ready for redemption--after the cooldown is complete. This make building on top of theOperatorStakingcontract much simpler.We also opted to revert when calls to
redeemorrequestRedeemspecify 0 shares.