Skip to content

Conversation

@eudelins-zama
Copy link
Contributor

@eudelins-zama eudelins-zama commented Dec 19, 2025

@mergify
Copy link

mergify bot commented Dec 19, 2025

🧪 CI Insights

Here's what we observed from your CI run for fe75761.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the golden Rust container image Docker build workflow to simplify its structure and add support for configurable Rust versions. The workflow is being modified to support new input parameters and use an updated version of the common Docker workflow template.

Key Changes

  • Added rust-version input parameter to allow dynamic Rust version selection (default: "stable")
  • Removed pull_request trigger and two jobs (check-changes and determine-tag) to simplify workflow
  • Changed input parameter naming from snake_case to kebab-case and modified tag to be optional with empty default
Comments suppressed due to low confidence (1)

.github/workflows/golden-container-images-docker-build-rust.yml:54

  • The ref parameter uses 'format' with 'github.event.inputs.tag' to create a git tag reference, but the tag input now has a default value of empty string and is not required. When the tag is empty, this will create an invalid reference 'refs/tags/' which could cause checkout failures. Consider adding a check to only set the ref when the tag is non-empty, or validate that the tag input is provided.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eudelins-zama eudelins-zama force-pushed the eudelins/chore/805/remove-root-toolchain branch 3 times, most recently from 54a4a97 to f84f88e Compare December 19, 2025 14:16
@eudelins-zama eudelins-zama force-pushed the eudelins/chore/805/remove-root-toolchain branch from f84f88e to 9518596 Compare December 19, 2025 14:17
@eudelins-zama eudelins-zama changed the title ci(common): update golden image docker build workflow ci(common): remove toolchain.txt Dec 19, 2025
@eudelins-zama eudelins-zama force-pushed the eudelins/chore/805/remove-root-toolchain branch 2 times, most recently from 96bb7c9 to a4e778e Compare December 19, 2025 15:34
@eudelins-zama eudelins-zama force-pushed the eudelins/chore/805/remove-root-toolchain branch from a4e778e to fe75761 Compare December 19, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants