-
Notifications
You must be signed in to change notification settings - Fork 2.4k
ci(common): remove toolchain.txt #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
286dc71 to
1a9722e
Compare
🧪 CI InsightsHere's what we observed from your CI run for fe75761. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the golden Rust container image Docker build workflow to simplify its structure and add support for configurable Rust versions. The workflow is being modified to support new input parameters and use an updated version of the common Docker workflow template.
Key Changes
- Added
rust-versioninput parameter to allow dynamic Rust version selection (default: "stable") - Removed
pull_requesttrigger and two jobs (check-changesanddetermine-tag) to simplify workflow - Changed input parameter naming from snake_case to kebab-case and modified tag to be optional with empty default
Comments suppressed due to low confidence (1)
.github/workflows/golden-container-images-docker-build-rust.yml:54
- The ref parameter uses 'format' with 'github.event.inputs.tag' to create a git tag reference, but the tag input now has a default value of empty string and is not required. When the tag is empty, this will create an invalid reference 'refs/tags/' which could cause checkout failures. Consider adding a check to only set the ref when the tag is non-empty, or validate that the tag input is provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/golden-container-images-docker-build-rust.yml
Outdated
Show resolved
Hide resolved
.github/workflows/golden-container-images-docker-build-rust.yml
Outdated
Show resolved
Hide resolved
.github/workflows/golden-container-images-docker-build-rust.yml
Outdated
Show resolved
Hide resolved
54a4a97 to
f84f88e
Compare
f84f88e to
9518596
Compare
96bb7c9 to
a4e778e
Compare
a4e778e to
fe75761
Compare
Closes https://github.com/zama-ai/fhevm-internal/issues/805