Skip to content

feat(charts): make configmap creation optional in contracts charts #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piizama wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(charts): make configmap creation optional in contracts charts #1634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/contracts/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: contracts
description: A helm chart to manage fhevm Smart Contracts Deployment
version: 0.7.5
version: 0.7.6
apiVersion: v2
keywords:
- fhevm
Expand Down
8 changes: 7 additions & 1 deletion charts/contracts/templates/sc-deploy-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ data:
deploy-contracts.sh: |
#!/bin/bash
set -eo pipefail


{{- if .Values.scDeploy.configmap.create }}
create_configmap() {
configmap_name="${1}"
if [[ -z "$configmap_name" ]]; then
Expand Down Expand Up @@ -77,6 +78,7 @@ data:
exit 0
fi
{{- end }}
{{- end }}

echo "executing deploy commands"
{{- range .Values.scDeploy.deployCommands }}
Expand Down Expand Up @@ -104,8 +106,10 @@ data:
{{- if .Values.scDeploy.verifyContracts }}
npx --no-install hardhat verify:verify || true
{{- end }}
{{- if .Values.scDeploy.configmap.create }}
echo "adding the current contracts version to the configmap"
kubectl patch configmap "${CONFIGMAP_NAME}" -p="{\"data\": {\"contracts.version\": \"{{ .Values.scDeploy.image.tag }}\"}}"
{{- end }}
upgrade-contracts.sh: |
#!/bin/bash
set -eo pipefail
Expand All @@ -121,6 +125,8 @@ data:
{{- range .Values.scUpgrade.upgradeCommands }}
{{ . | nindent 4 }}
{{- end }}
{{- if .Values.scDeploy.configmap.create }}
echo "updating the contracts version to the configmap"
CONFIGMAP_NAME="{{ .Values.scDeploy.configmap.name }}"
kubectl patch configmap "${CONFIGMAP_NAME}" -p="{\"data\": {\"contracts.version\": \"{{ .Values.scDeploy.image.tag }}\"}}"
{{- end }}
1 change: 1 addition & 0 deletions charts/contracts/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ scDeploy:

# ConfigMap to store deployed contract addresses
configmap:
create: true
name: "sc-addresses"
annotations:

Expand Down