fix(protocol-contracts): mitigate ERC4626 inflation attack with decimal offset (L-06) #1684
+84
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al offset (L-06) Set _decimalsOffset to 2 in OperatorStaking vault to mitigate the inflation attack where the first depositor can lose tokens.
🧪 CI InsightsHere's what we observed from your CI run for ff4957b. 🟢 All jobs passed!But CI Insights is watching 👀 |
melanciani
commented
Dec 30, 2025
| */ | ||
| function _decimalsOffset() internal view virtual returns (uint8) { | ||
| return 0; | ||
| return 2; |
Contributor
Author
There was a problem hiding this comment.
@arr00 we would like your opinion on this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_decimalsOffsetto 2 in OperatorStaking vault to mitigate the ERC4626 inflation attackrefs https://github.com/zama-ai/fhevm-internal/issues/826