-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(coprocessor): do not update is_completed on unallowed handles #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/0.10.x
Are you sure you want to change the base?
Conversation
🧪 CI InsightsHere's what we observed from your CI run for c1421d9. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes an issue where the is_completed flag was being incorrectly set for unallowed computation handles. The fix ensures that only successfully computed handles (which are allowed) have their is_completed status updated, and sets is_completed = true immediately for unallowed computations when they are inserted into the database.
Key changes:
- Modified handle tracking logic to only mark successfully computed handles as complete
- Added
is_completedcolumn to the computation insertion SQL with logic to set it based onis_allowedstatus - Wrapped database operations in conditional blocks to avoid unnecessary queries when there's no data to process
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| coprocessor/fhevm-engine/tfhe-worker/src/tfhe_worker.rs | Changed handles_to_update initialization from including intermediate and unneeded handles to only including successfully computed results; added conditional guards around database operations |
| coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs | Added is_completed column to computation INSERT statement, setting it to !log.is_allowed to immediately mark unallowed computations as complete |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs
Show resolved
Hide resolved
9113537 to
2671d3b
Compare
2671d3b to
2373b73
Compare
2373b73 to
c1421d9
Compare
No description provided.