Skip to content

Conversation

@antoniupop
Copy link
Collaborator

No description provided.

@antoniupop antoniupop requested a review from a team as a code owner December 30, 2025 19:04
@cla-bot cla-bot bot added the cla-signed label Dec 30, 2025
@mergify
Copy link

mergify bot commented Dec 30, 2025

🧪 CI Insights

Here's what we observed from your CI run for c1421d9.

🟢 All jobs passed!

But CI Insights is watching 👀

deasydoesit
deasydoesit previously approved these changes Dec 30, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where the is_completed flag was being incorrectly set for unallowed computation handles. The fix ensures that only successfully computed handles (which are allowed) have their is_completed status updated, and sets is_completed = true immediately for unallowed computations when they are inserted into the database.

Key changes:

  • Modified handle tracking logic to only mark successfully computed handles as complete
  • Added is_completed column to the computation insertion SQL with logic to set it based on is_allowed status
  • Wrapped database operations in conditional blocks to avoid unnecessary queries when there's no data to process

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
coprocessor/fhevm-engine/tfhe-worker/src/tfhe_worker.rs Changed handles_to_update initialization from including intermediate and unneeded handles to only including successfully computed results; added conditional guards around database operations
coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs Added is_completed column to computation INSERT statement, setting it to !log.is_allowed to immediately mark unallowed computations as complete

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rudy-6-4
rudy-6-4 previously approved these changes Dec 30, 2025
@antoniupop antoniupop force-pushed the antoniu/hotfix/restrict-update-queries branch from 2671d3b to 2373b73 Compare December 30, 2025 19:20
rudy-6-4
rudy-6-4 previously approved these changes Dec 30, 2025
@antoniupop antoniupop force-pushed the antoniu/hotfix/restrict-update-queries branch from 2373b73 to c1421d9 Compare December 30, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants