Conversation
jot2re
changed the base branch from
main
to
tore/feat/support-multiple-signcryption
October 1, 2026 08:28
Consolidated Tests Results 2026-10-01 - 13:45:56 from rust-testingFailed Tests
Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Refactor signcryption process to use Zeroizing for payload. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…e/simplification-verf-logic
Base automatically changed from
tore/feat/support-multiple-signcryption
to
main
October 2, 2026 10:44
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the logic to just fail in validation of setups that have never been implemented. I.e. if EIP712 domain is missing and
signatureandexternal_signatureis set is a failure.The PR also includes a fix to ensure that the central KMS can boot if there is no signing key present (there was a bug before preventing it from doing so), and the PR also includes a refactoring to ensure that not just an ECDSA key is loaded in recovery mode, but all verification keys that are needed to recover.
Also fixes a small issue with
test_validate_new_mpc_epoch_requestwhere the test description did not match what it did.Related issue(s)
PR Checklist
Tick all that apply — by ticking I attest the item holds; justify any deviation in the description above.
chore: ...).pubitem and test coverage has not decreased.TODO(#issue).unwrap/expect/paniconly in tests or for invariant bugs (documented if present).devopslabel + infra notified + review requested.!and affected teams notified.Zeroize+ZeroizeOnDropimplemented.unsafe; if unavoidable: minimal, justified, documented, and test/fuzz covered.Dependency Update Questionnaire (only if deps changed or added)
More details in CONTRIBUTING.md and AGENTS.md.