Skip to content

Conversation

@soonum
Copy link
Contributor

@soonum soonum commented Dec 10, 2025

This is the first batch of unit tests. More cases will follow to improve coverage along with integration tests to test file generation.


This change is Reviewable

@soonum soonum requested a review from IceTDrinker December 10, 2025 16:40
@soonum soonum self-assigned this Dec 10, 2025
@soonum soonum added the ci label Dec 10, 2025
@cla-bot cla-bot bot added the cla-signed label Dec 10, 2025
@soonum soonum force-pushed the dt/ci/refactor_data_extractor branch 2 times, most recently from 86139f7 to cb3cf30 Compare December 10, 2025 17:29
Base automatically changed from dt/ci/refactor_data_extractor to main December 11, 2025 08:35
This is the first batch of unit tests. More cases will follow to improve coverage along with integration tests to test file generation.
@soonum soonum force-pushed the dt/ci/unittest_data_extractor branch from 4d2ead9 to 546def0 Compare December 11, 2025 08:40
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the tests run in CI somehow ?

@IceTDrinker reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @soonum)


ci/data_extractor/tests/test_unit.py line 351 at r1 (raw file):

if __name__ == "__main__":
    unittest.main()

unclear to me whether things are actually tested


ci/data_extractor/tests/__init__.py line 5 at r1 (raw file):

# Add data_extractor sources to the Python path.
path = os.path.abspath(os.path.join(os.path.dirname(__file__), "../src"))

this is yuck, isn't there a way to properly load a python module ?

if you need to setup a project with uv (written in rust so should be ok to install) or something please do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants