Repository navigation
merge recent upstream - #2
Merged
Merged
Conversation
Bumps [taiki-e/cache-cargo-install-action](https://github.com/taiki-e/cache-cargo-install-action) from 2 to 3. - [Release notes](https://github.com/taiki-e/cache-cargo-install-action/releases) - [Changelog](https://github.com/taiki-e/cache-cargo-install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/cache-cargo-install-action@v2...v3) --- updated-dependencies: - dependency-name: taiki-e/cache-cargo-install-action dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
```
error: `panic` is ambiguous
--> src/./alg_tests.rs:699:26
|
699 | unhandled => panic!("extend der2text for tag 0x{unhandled:x?}"),
| ^^^^^ ambiguous name
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #147319 <rust-lang/rust#147319>
= note: ambiguous because of a conflict between a name from a glob import and an outer scope during import or macro resolution
```
This also means the panic macro isn't ambiguous so we can drop explicit panic imports.
Of the form:
```
error: this `match` expression can be replaced with `?`
--> src/crl/types.rs:357:13
|
357 | / match revoked_cert_result {
358 | | Err(e) => return Err(e),
359 | | Ok(revoked_cert) => {
360 | | if revoked_cert.serial_number.eq(serial) {
... |
364 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#question_mark
= note: `-D clippy::question-mark` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::question_mark)]`
```
titouantanguy
approved these changes
Aug 21, 2026
titouantanguy
left a comment
titouantanguy
left a comment
There was a problem hiding this comment.
Minor changes on top of the sync with upstream LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.