Skip to content

Commit

Permalink
Fix tests by @abarciauskas-bgse
Browse files Browse the repository at this point in the history
Ab/fix tests
  • Loading branch information
jsignell authored Jan 31, 2025
2 parents 42414f0 + dc4ed8b commit 77b1088
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions ci/upstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ channels:
- conda-forge
- nodefaults
dependencies:
- xarray>=2024.10.0,<2025.0.0
- xarray>=2025.1.1
- h5netcdf
- h5py
- hdf5
Expand All @@ -29,6 +29,6 @@ dependencies:
- fsspec
- pip
- pip:
- icechunk==0.1.0a12 # Installs python-zarr v3 as dependency
- icechunk>=0.1.0a12 # Installs python-zarr v3 as dependency
- git+https://github.com/fsspec/kerchunk.git@main
- imagecodecs-numcodecs==2024.6.1
4 changes: 3 additions & 1 deletion virtualizarr/tests/test_codecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ def test_manifest_array_zarr_v2_normalized(self):

# Get codecs and verify
actual_codecs = get_codecs(manifest_array, normalize_to_zarr_v3=True)
expected_codecs = manifest_array.zarray._v3_codec_pipeline()
expected_codecs = (
manifest_array.zarray.serializer(),
) + manifest_array.zarray._v3_codec_pipeline()
assert actual_codecs == expected_codecs

@requires_zarr_python_v3
Expand Down
2 changes: 1 addition & 1 deletion virtualizarr/tests/test_writers/test_zarr.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def test_zarr_v3_metadata_conformance(tmpdir, vds_with_manifest_arrays: Dataset)
assert isinstance(metadata["fill_value"], (bool, int, float, str, list))
assert (
isinstance(metadata["codecs"], list)
and len(metadata["codecs"]) > 1
and len(metadata["codecs"]) == 1
and all(isconfigurable(codec) for codec in metadata["codecs"])
)

Expand Down

0 comments on commit 77b1088

Please sign in to comment.