Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roundtrip tests kerchunk tests without requiring kerchunk #405

Closed
wants to merge 2 commits into from

Conversation

jsignell
Copy link
Contributor

It benefits this library to run as many tests as possible in as many environments as possible. So it is good to run tests that exercise reading/writing kerchunk-style references even when kerchunk is not available in the testing environment.

That being said. This doesn't currently pass in the upstream env - maybe the xarray zarr 3 reader doesn't do well with fsspec?

@jsignell
Copy link
Contributor Author

jsignell commented Jan 30, 2025

I rebased #393 off this PR and reimagined it as added roundtripping to icechunk as just another option. I am pretty happy with how bd95d60 cleans these tests up and makes it easy to imagine adding more roundtrip tests.

@jsignell jsignell mentioned this pull request Jan 30, 2025
6 tasks
@jsignell
Copy link
Contributor Author

Closing this. See note on issue

@jsignell jsignell closed this Jan 30, 2025
@jsignell jsignell deleted the to_kerchunk branch January 30, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roundtrip dict and json kerchunk tests without depending on kerchunk library
1 participant