Update usage.md with append method for icechunk #409
Conversation
abarciauskas-bgse
commented
Jan 30, 2025
abarciauskas-bgse
commented
- Closes Support appending to icechunk store #311
abarciauskas-bgse
temporarily deployed
to
test-release
GitHub Actions
Inactive
| @@ -431,14 +431,27 @@ We can also write these references out as an [IcechunkStore](https://icechunk.io | |||
| ```python | |||
| # create an icechunk repository, session and write the virtual dataset to the session | |||
| from icechunk import Repository, Storage, VirtualChunkContainer, local_filesystem_storage | |||
| storage = local_filesystem_storage(str('combined')) | |||
There was a problem hiding this comment.
I wasn't really sure why the argument was str('combined') but happy to revert this change if there is a reason
There was a problem hiding this comment.
I mean this can't possibly be necessary, because str(<str obj>) == <str obj>, even down to having the same hash. So you should be able to get rid of the enclosing str() call.
There was a problem hiding this comment.
oh yes, I did already get rid of the enclosing str call (see change below), but I also changed the string, which I think more clearly indicates a local path
There was a problem hiding this comment.
Thanks @abarciauskas-bgse - these two minor suggestions and then please merge!
docs/usage.md
Outdated
|
|
||
| #### Append to an existing Icechunk Store | ||
|
|
||
| You can append a virtual dataset to an existing Icechunk store using the `append_dim` argument. This is especially useful for ongoing datasets. Note that Zarr does not currently support concatenating datasets with different codecs or chunk shapes. |
There was a problem hiding this comment.
I would change "ongoing" to "datasets that expand over time" or something like that.
abarciauskas-bgse
temporarily deployed
to
test-release
GitHub Actions
Inactive
