Allow pathlib use in convenience and filesystem stores

Author: clbarnes

zarr/convenience.py

@@ -1,6 +1,7 @@
 """Convenience functions for storing and loading data."""
 import io
 import itertools
+import os
 import re
 from collections.abc import Mapping
 
@@ -100,6 +101,10 @@ def open(store=None, mode='a', **kwargs):
             raise PathNotFoundError(path)
 
 
+def _might_close(path):
+    return isinstance(path, (str, os.PathLike))
+
+
 def save_array(store, arr, **kwargs):
     """Convenience function to save a NumPy array to the local file system, following a
     similar API to the NumPy save() function.
@@ -131,7 +136,7 @@ def save_array(store, arr, **kwargs):
         array([   0,    1,    2, ..., 9997, 9998, 9999])
 
     """
-    may_need_closing = isinstance(store, str)
+    may_need_closing = _might_close(store)
     store = normalize_store_arg(store, clobber=True)
     try:
         _create_array(arr, store=store, overwrite=True, **kwargs)
@@ -202,7 +207,7 @@ def save_group(store, *args, **kwargs):
     if len(args) == 0 and len(kwargs) == 0:
         raise ValueError('at least one array must be provided')
     # handle polymorphic store arg
-    may_need_closing = isinstance(store, str)
+    may_need_closing = _might_close(store)
     store = normalize_store_arg(store, clobber=True)
     try:
         grp = _create_group(store, overwrite=True)

zarr/creation.py

@@ -1,3 +1,5 @@
+import os
+from pathlib import Path
 from warnings import warn
 
 import numpy as np
@@ -148,7 +150,9 @@ def create(shape, chunks=True, dtype=None, compressor='default',
 def normalize_store_arg(store, clobber=False, storage_options=None, mode='w'):
     if store is None:
         return dict()
-    elif isinstance(store, str):
+    if isinstance(store, Path):
+        store = os.fspath(store)
+    if isinstance(store, str):
         mode = mode if clobber else "r"
         if "://" in store or "::" in store:
             return FSStore(store, mode=mode, **(storage_options or {}))

zarr/storage.py

@@ -20,6 +20,7 @@
 import multiprocessing
 import operator
 import os
+from pathlib import Path
 import re
 import shutil
 import sys