Mark V3 API experimental #1032
Merged
Mark V3 API experimental #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following discussion at this week's community call, a few additional precautions are being implemented here: - [x] rename the var ZARR_V3_API_AVAILABLE to ZARR_V3_EXPERIMENTAL_API - [x] add an assertion to prevent use of zarr_version=3 w/o the var
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1032 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 34 34
Lines 13788 13847 +59
=======================================
+ Hits 13781 13840 +59
Misses 7 7
|
joshmoore
force-pushed
the
v3-experimental
branch
from
e261a06 to
c1f9d5d
Compare
|
Restarting failed CI jobs |
|
Ok. That got us to green. Propose to release this ASAP as cc: @MSanKeys963 |
|
Thanks for leading this @joshmoore. |
Deferring to @jakirkham on that one. |
|
We can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion at this week's community call, a few additional
precautions are being implemented here:
All tests should continue passing in GHA since the variable is set. Local runs, however, need some consideration in order to properly
xfail.See also #1020