Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to label PRs with "needs release notes" #1239

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

Saransh-cpp
Copy link
Contributor

See #1193 (comment)

This will -

  • label a PR with "needs release notes" if docs/release.rst has not been edited
  • remove the label as soon as docs/release.rst is edited

A working demo - Saransh-cpp#1

This will encourage (or maybe require, depending on the maintainers) developers to update release.rst with every PR!

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jakirkham
Copy link
Member

Interesting! This seems useful. Thanks Saransh 🙏

Wonder how this looks if we change the release note process to use release fragments ( #829 )?

@joshmoore
Copy link
Member

My guess would be: - any: ['!.release-notes/*'] (or similar) would work, saying "you must have added a file under this directory.

@Saransh-cpp
Copy link
Contributor Author

- any: ['!.release-notes/*']

Yes, this should work according to the examples listed in their README.

@Saransh-cpp Saransh-cpp force-pushed the pr-label branch 2 times, most recently from 5d1919b to 7d65924 Compare November 7, 2022 06:24
@joshmoore
Copy link
Member

Nice!

Screen Shot 2022-11-09 at 20 02 20

@jakirkham
Copy link
Member

Could you please send a PR to add this to Numcodecs too?

@jakirkham jakirkham enabled auto-merge (squash) November 15, 2022 19:16
@jakirkham
Copy link
Member

Thanks Saransh! 🙏 Merging when CI passes

@jakirkham jakirkham disabled auto-merge November 15, 2022 19:17
@jakirkham jakirkham enabled auto-merge (squash) November 15, 2022 19:19
@jakirkham
Copy link
Member

(needed a release note 😉)

@jakirkham jakirkham merged commit d5891b2 into zarr-developers:main Nov 15, 2022
@Saransh-cpp Saransh-cpp deleted the pr-label branch November 16, 2022 05:55
@Saransh-cpp
Copy link
Contributor Author

Haha, missed that!

@joshmoore
Copy link
Member

(needed a release note 😉)
Haha, missed that!

🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants