Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consolidated metadata): skip .zmetadata key in members search #2356

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Oct 13, 2024

Small patch on the back of #1161.

Without this change, the logic in members was identifying .zmetadata as a valid key in the store and looking for its children (e.g. foo/.zmetadata/.zarray). The result was a bunch of noisy warnings about unrecognized keys.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@d-v-b
Copy link
Contributor

d-v-b commented Oct 13, 2024

I don't see a problem description or bug report in the linked issue (maybe i missed it). Is the problem this PR solves basically that zarr-python was emitting noisy warnings when encountering .zmetadata during members listing?

@jhamman
Copy link
Member Author

jhamman commented Oct 13, 2024

@d-v-b - yes, exactly. I've added a description to this point.

Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for this

@jhamman jhamman merged commit b26cf98 into zarr-developers:v3 Oct 14, 2024
20 checks passed
@jhamman jhamman deleted the fix/consolidated-metadata-members branch October 14, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants