Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use unsigned bytes to back Buffer #2738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use unsigned bytes to back Buffer #2738

wants to merge 1 commit into from
+12 −12

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jan 21, 2025

This makes compressors consistent with v2, and seems more correct than signed bytes.

Fixes #2735

Note that this does not implement accepting both signed and unsigned, as there wasn't a conclusion in #2735 about that.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented in docs/release-notes.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@QuLogic
Copy link
Contributor Author

QuLogic commented Jan 21, 2025

PS, going to ignore tests for now.

@QuLogic
Use unsigned bytes to back Buffer
01c6e35 
This makes compressors consistent with v2, and seems more correct than
signed bytes.

Fixes zarr-developers#2735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer uses signed bytes with v2 compressors
1 participant
@QuLogic