Skip to content

Update labeler config for major version increment #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update labeler config for major version increment #2747

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbe89b8
Update labeler config for major version increment
moradology Jan 22, 2025
1c9a947
Revert labeler workflow to pull_request_target
moradology Jan 22, 2025
49211d3
Merge branch 'main' into fix/update-labeler
jhamman Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/labeler.yml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
- needs release notes:
- all:
- changed-files:
- any-glob-to-any-file: 'changes/*.rst'
needs release notes:
- changed-files:
- any-glob-to-any-file: 'changes/*.rst'
9 changes: 7 additions & 2 deletions .github/workflows/needs_release_notes.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: "Pull Request Labeler"

on:
- pull_request_target
pull_request_target

jobs:
labeler:
@@ -11,7 +11,12 @@ jobs:
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9 # v5.0.0
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to checkout the repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure to find .github/labeler.yml, which was the first error being encountered on #2533 and led me to looking into this


- name: Run Pull Request Labeler
uses: actions/labeler@v5.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we switch back to using the SHA instead? It will be updated find by dependabot, but it's generally recommended to use the SHA instead of a tag for security reasons.

with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
sync-labels: true
Loading