Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump h5py from 2.10.0 to 3.2.1 #749

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Bump h5py from 2.10.0 to 3.2.1 #749

merged 1 commit into from
Jun 17, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 14, 2021 •
edited
Loading

Bumps h5py from 2.10.0 to 3.2.1.

Release notes

Sourced from h5py's releases.

3.2.1

No release notes provided.

3.2.0

No release notes provided.

3.1.0

No release notes provided.

3.0.0

https://docs.h5py.org/en/latest/whatsnew/3.0.html

3.0.0rc1

No release notes provided.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 14, 2021
@dependabot dependabot bot force-pushed the dependabot/pip/h5py-3.2.1 branch 2 times, most recently from c5ca8b7 to 5f168bb Compare May 18, 2021 07:46
@joshmoore
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 18, 2021

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@joshmoore
Copy link
Member

Ah, a strike against Python 3.6

@dependabot dependabot bot force-pushed the dependabot/pip/h5py-3.2.1 branch 3 times, most recently from 2b118c0 to 19cf9eb Compare May 27, 2021 07:13
@dependabot dependabot bot force-pushed the dependabot/pip/h5py-3.2.1 branch 2 times, most recently from c338fc3 to ea3a27b Compare June 1, 2021 19:37
@joshmoore joshmoore mentioned this pull request Jun 2, 2021
Closed
@dependabot dependabot bot force-pushed the dependabot/pip/h5py-3.2.1 branch from ea3a27b to b3e0788 Compare June 16, 2021 18:26
@joshmoore
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 16, 2021

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@joshmoore
Copy link
Member

Aha:

The conflict is caused by:
    The user requested numpy==1.16.4
    numcodecs 0.7.3 depends on numpy>=1.7
    pytest-doctestplus 0.4.0 depends on numpy>=1.10
    h5py 3.2.1 depends on numpy>=1.17.5; python_version == "3.8"

Does anyone know if it's not safe for us to drop the numpy==1.16.4 build logic?

@jakirkham
Copy link
Member

Bumping NumPy to 1.17 seems reasonable to me

joshmoore added a commit to joshmoore/zarr-python that referenced this pull request Jun 17, 2021
@joshmoore
Drop the additional numpy 1.16 test
7bd70a0 
see:
 * zarr-developers#774 which drops Python 3.6
 * zarr-developers#749 which bumps h5py to 3.2
@joshmoore joshmoore mentioned this pull request Jun 17, 2021
Merged
@joshmoore
Copy link
Member

Ongoing in #778

joshmoore added a commit that referenced this pull request Jun 17, 2021
@joshmoore
Drop the additional numpy 1.16 test (#778)
dd0e779 
* Drop the additional numpy 1.16 test

see:
 * #774 which drops Python 3.6
 * #749 which bumps h5py to 3.2

* Test numpy 1.17 as the 'old' version
@joshmoore
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pip/h5py-3.2.1 branch from 9faa946 to de5b5f5 Compare June 17, 2021 07:33
@joshmoore
Copy link
Member

Again, builds are green except for the numpy 1.16 build that was removed in #778. Merging though still open to opinions on the range of versions of h5py (and other libraries) that should be supported.

@joshmoore joshmoore merged commit eaaa581 into master Jun 17, 2021
@joshmoore joshmoore deleted the dependabot/pip/h5py-3.2.1 branch June 17, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmoore @jakirkham