Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9.0 release notes #812

Merged
merged 2 commits into from
Aug 23, 2021
Merged

2.9.0 release notes #812

merged 2 commits into from
Aug 23, 2021

Conversation

joshmoore
Copy link
Member

With #773 now merged (:tada:), I'd like to get this out (today? Even thought it's a Friday?!) but it's a fairly big one. Any thoughts? Would anyone want an RC to test with?

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #812 (102cc5c) into master (ce04aaa) will decrease coverage by 0.08%.
The diff coverage is 98.41%.

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
- Coverage   99.94%   99.85%   -0.09%     
==========================================
  Files          30       31       +1     
  Lines       10586    10613      +27     
==========================================
+ Hits        10580    10598      +18     
- Misses          6       15       +9     
Impacted Files Coverage Δ
zarr/tests/test_dim_separator.py 97.56% <97.56%> (ø)
zarr/core.py 100.00% <100.00%> (ø)
zarr/n5.py 100.00% <100.00%> (ø)
zarr/storage.py 99.30% <100.00%> (-0.70%) ⬇️
zarr/tests/test_storage.py 100.00% <100.00%> (ø)

@bnavigator
Copy link

Hi, I just tested to build your 2_9_0 branch for a package for openSUSE Tumbleweed (which has fsspec 2021.7.0) and I still get

[   89s] FAILED zarr/tests/test_core.py::TestArrayWithFSStoreNested::test_array_2d - A...
[   89s] FAILED zarr/tests/test_core.py::TestArrayWithFSStoreNestedPartialRead::test_array_2d
[   89s] FAILED zarr/tests/test_storage.py::TestFSStore::test_create - AttributeError:...

(#786, #802)

With #802 applied, the test_array tests pass, only test_create still fails.

Could you try to include #802 into the release and fix the last one (here or in fsspec) please?

@bnavigator
Copy link

I just found out, that fsspec/filesystem_spec#710 should fix the test_create failure.

@joshmoore
Copy link
Member Author

Hey @bnavigator. Thanks for giving this a try!

I just found out, that intake/filesystem_spec#710 should fix the test_create failure.

Agreed. Just waiting on the next release.

Could you try to include #802 into the release and fix the last one (here or in fsspec) please?

Do you agree #802 is only needed if one bumps fsspec to 2021.7.0? So, if fsspec is pinned to 2021.6 or earlier (or one installs from the mainline) that 2.9.0 currently works?

@bnavigator
Copy link

bnavigator commented Aug 21, 2021

Do you agree #802 is only needed if one bumps fsspec to 2021.7.0? So, if fsspec is pinned to 2021.6 or earlier (or one installs from the mainline) that 2.9.0 currently works?

Yes, but pinning to an earlier version is not an option for openSUSE Tumbleweed. Other packages already triggered the update of fsspec to 2021.7 causing the python-zarr package to fail. If you are not going to merge #802 into 2.9.0, I will have to apply the patch to our package manually.

@joshmoore
Copy link
Member Author

Agreed. Let's not include #802 just yet. I imagine an fsspec release will be along soon.

Merging and moving forward with the release.

@joshmoore joshmoore merged commit adc430a into zarr-developers:master Aug 23, 2021
@joshmoore joshmoore deleted the 2_9_0 branch August 23, 2021 06:51
@bnavigator
Copy link

For the record: test_core::*::test_array_2d still fail on 2.9.0 with fsspec-2021.7 and fsspec/filesystem_spec#710 applied to it. You still need #802 with a new fsspec release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants