Skip to content

set normalize_keys=False in fsstore constructor #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Sep 28, 2021

Set normalize_keys to False by default in FSStore. Addresses #841

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #842 (46094a0) into master (78eb8b7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          31       31           
  Lines       10936    10936           
=======================================
  Hits        10930    10930           
  Misses          6        6           
Impacted Files Coverage Δ
zarr/storage.py 100.00% <100.00%> (ø)

@d-v-b
Copy link
Contributor Author

d-v-b commented Sep 28, 2021

I think if we are going to require that constructors take the same default argument, there should be a test for it (such a test would have prevented me from making this change in the first place). This would require changing all the store test classes, so I deemed it out of scope for this patch.

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR, @d-v-b. Sorry for the slow release (I was traveling! 😉) Going to turn this into 2.10.1 now.

Regarding the constructor arguments, will it help if we define the defaults somewhere as constants?

@joshmoore joshmoore merged commit e70c4b1 into zarr-developers:master Sep 30, 2021
joshmoore referenced this pull request in ome/ome-zarr-py Jan 8, 2022
For writing HCS datasets where group names are case-sensitive (e.g. A), this
option alters the name and creates a mismatch with the plate metadata.
@d-v-b d-v-b deleted the normalize_keys_fix branch December 21, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants