Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocks_to_decompress not used in read_part function #861

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

boazmohar
Copy link
Contributor

Unused variable, as indicated by lgtm.com

TODO:

  • Add unit tests and/or doctests in docstrings (all tests passed locally)
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@joshmoore
Copy link
Member

Interesting. This is perhaps another piece in the puzzle to #859 (comment)

@jakirkham
Copy link
Member

@andrewfulton9, could you please review?

@andrewfulton9
Copy link
Contributor

This PR looks good to me. I must have forgot to delete that code when I changed how the blocks where looped through.

Interesting. This is perhaps another piece in the puzzle to #859 (comment)

I don't think so. I'm sure that self.nblocks did not always equal 1 when the partial read capability was added. I'll take a look.

@joshmoore
Copy link
Member

Thanks @boazmohar and @andrewfulton9 for the review!

@joshmoore joshmoore merged commit 1d821d4 into zarr-developers:master Nov 15, 2021
@boazmohar boazmohar deleted the unused-variable branch November 15, 2021 12:06
@joshmoore
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants