Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defines blocksize for array, updates hexdigest values #867

Merged

Conversation

andrewfulton9
Copy link
Contributor

@andrewfulton9 andrewfulton9 commented Nov 12, 2021

[Description of PR]
Should fix partial read test by defining blocksize for Blosc compression.

related to conversation in #859

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #867 (95bcdbd) into master (a92550b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #867   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          32       32           
  Lines       11204    11204           
=======================================
  Hits        11198    11198           
  Misses          6        6           
Impacted Files Coverage Δ
zarr/tests/test_core.py 100.00% <100.00%> (ø)

@joshmoore
Copy link
Member

Wow. Thanks, @andrewfulton9! I'll merge this and try to get all the related conversations green. We might need to review use of Blosc() especially:

(base) /opt/zarr-python $git grep -nE "Blosc\(" zarr/storage.py
zarr/storage.py:80:    default_compressor = Blosc()

@joshmoore joshmoore merged commit 4e6e0b2 into zarr-developers:master Nov 15, 2021
@joshmoore joshmoore mentioned this pull request Nov 15, 2021
2 tasks
@joshmoore
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants