Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tobytes in docs #907

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Use tobytes in docs #907

merged 1 commit into from
Dec 10, 2021

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Dec 10, 2021 •
edited
Loading

Pulls doc fixes from PR ( #636 ). Namely using tobytes in docs (the preferred NumPy API for this functionality going forward).

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jakirkham jakirkham mentioned this pull request Dec 10, 2021
Closed
@jakirkham
Copy link
Member Author

cc @joshmoore

joshmoore
joshmoore approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshmoore joshmoore merged commit dc3f839 into zarr-developers:master Dec 10, 2021
@jakirkham jakirkham deleted the pr_636_doc_fixes branch December 10, 2021 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore joshmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakirkham @joshmoore @Carreau