add smoke test (uses darkside wallet server)#507
Merged
LarryRuane merged 1 commit intozcash:masterfrom Mar 10, 2025
Merged
Conversation
aabc866 to
3ea4405
Compare
Collaborator
Author
|
Force pushed to add copyright comment to new file |
Collaborator
Author
|
The following files are generated, so don't need review:
|
3ea4405 to
3786cfa
Compare
Collaborator
Author
|
Force pushed to test donation address (#506 just merged) |
y4ssi
approved these changes
Mar 10, 2025
Contributor
y4ssi
left a comment
There was a problem hiding this comment.
utACK, but suggest improving dependency documentation in smoke-test.bash
Contributor
There was a problem hiding this comment.
The script relies on external tools (grpcurl, jq, curl, timeout), but it doesn't explicitly document installation or pre-checks.
Suggestions:
- Add a "Requirements" section at the top listing dependencies and installation commands (e.g.,
apt-get install grpcurl jq curl). - Include a pre-check to verify dependencies before execution:
command -v grpcurl >/dev/null 2>&1 || { echo "Error: grpcurl not installed."; exit 1; }
- Improve error handling to provide clearer messages when dependencies are missing.
More tests could be added later; this covers the basics.
3786cfa to
7efb157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "smoke" test. This is analogous to zcash's
qa/zcash/smoke_tests.py(but the details are completely different). Our existing tests don't exercise the gRPC interface; this test addresses that deficiency. It doesn't exercise every gRPC (it could be extended), but is still a significant improvement in test coverage.I've wanted to write this PR for a long time, but the tipping point was #505 (not yet merged at this time)-- that PR changes the gRPC interface internals (not functional behavior) quite a bit, and I didn't have a way to test those changes except manually. I'd like to get this PR merged first, before merging #505.
This test could be added to CI (it takes about 9 seconds to run), but for now, just run it manually with no arguments. It does not require running a
zcashdinstance (since it uses the darkside wallet test infrastructure). It does require:grpcurljq(but this dependency could be eliminated pretty easily).