Fix infinite loop in darkside setPrevhash (#552)#553
Open
mnm458 wants to merge 2 commits intozcash:masterfrom
Open
Fix infinite loop in darkside setPrevhash (#552)#553mnm458 wants to merge 2 commits intozcash:masterfrom
mnm458 wants to merge 2 commits intozcash:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix infinite loop in darkside setPrevhash by computing block hash after updating prevhash bytes.
Summary
setPrevhash()was parsing each block's raw bytes before writing the corrected prevhash, then computing the block hash from the stale parsed struct. This caused subsequent blocks to have incorrect prevhash values, leadingBlockIngestorinto an infinite add/reorg loop whenApplyStagedwas called.The fix moves the
copy()of the prevhash to occur beforeParseFromSlice(), so the hash is computed from the updated bytes.Closes #552
Documentation
No external documentation changes required. The fix corrects internal behavior to match the existing documented darkside tutorial in
docs/darksidewalletd.md.Test Plan
TestSetPrevhashChainConsistencyincommon/darkside_test.gosetPrevhashrunsgo test ./...)docs/darksidewalletd.mdand confirmApplyStagedno longer produces infinite log output