ZIP 2005: Move to Proposed (and minor cleanups) - #1276
Merged
Conversation
daira
force-pushed
the
zip-2005-to-proposed
branch
from
May 18, 2026 12:42
fd7cecf to
deb8472
Compare
ValarDragon
previously approved these changes
May 18, 2026
ValarDragon
left a comment
ValarDragon
left a comment
Collaborator
There was a problem hiding this comment.
Agreed! Lets get it to wallets
The QROM proofs are good to go imo
daira
force-pushed
the
zip-2005-to-proposed
branch
3 times, most recently
from
May 18, 2026 13:35
cd1264c to
57338fe
Compare
…f rivk. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
zip-2005-to-proposed
branch
from
May 18, 2026 13:47
57338fe to
4f633a8
Compare
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
zip-2005-to-proposed
branch
4 times, most recently
from
May 18, 2026 14:57
00af118 to
6ea53c6
Compare
daira
changed the title
…n overspecification. Change it to say that it doesn't matter which of the allowed lead bytes is used. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
pre_esk is now inlined for Sapling and Orchard, and pre_rcm is inlined for Sapling. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
zip-2005-to-proposed
branch
from
May 18, 2026 20:00
6ea53c6 to
aa78d85
Compare
ebfull
reviewed
May 18, 2026
… section. Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
Signed-off-by: Daira-Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
zip-2005-to-proposed
branch
from
May 18, 2026 20:23
aa78d85 to
bc16325
Compare
ebfull
approved these changes
May 18, 2026
nuttycom
approved these changes
May 19, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #1275. fixes #1277