Skip to content

Conversation

@zeld-a
Copy link
Contributor

@zeld-a zeld-a commented Oct 28, 2025

Closes #39937

Release Notes:

  • Fixed expand/collapse all entries not working in singleton buffer mode

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 28, 2025
@zeld-a
Copy link
Contributor Author

zeld-a commented Oct 28, 2025

The issue requested a test, but I am not familiar with the gpui tests so I did not include one. If someone would guide me, I could definitely provide that.

Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

For the tests, you can check out the commit I've mentioned in the comment: #33490

That one had added a test, we can extend the existing one with more actions calls and asserts, or copy the initialization into a new test and assert things there.

@maxdeviant maxdeviant changed the title Outline Panel: Fix collaps/expand all entries outline_panel: Fix collapse/expand all entries Oct 28, 2025
@SomeoneToIgnore SomeoneToIgnore self-assigned this Oct 29, 2025
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you a lot for pushing this to the final and adding more tests!

@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) October 30, 2025 21:27
@SomeoneToIgnore SomeoneToIgnore merged commit 03c6d62 into zed-industries:main Oct 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outline panel: Collapse and Expand all Entries do not do anything

2 participants