ci: Notarize in parallel (different flavor) #41392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Conrad Irwin <[email protected]>
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
claytonrcarter
added a commit
to claytonrcarter/zed
that referenced
this pull request
Oct 29, 2025
This was (inadvertently, I think) broken by zed-industries#41392 Ref: 4cc6d6a Ref: zed-industries#41392
ConradIrwin
added a commit
that referenced
this pull request
Oct 30, 2025
I just pulled and ran a local build via `script/bundle-mac -l -i` but found that the resulting bundle wasn't installed as expected. (me: "ToggleAllDocks!! Wait! Where is it?!") Looking into, it looks like the `-l` flag was removed in #41392, leaving the `$local_only` var orphaned, which then left the `-i/$local_install` flag unreachable. I suspect that this was unintentional, so this PR re-adds the `-l/$local_only` flag to `script/bundle-mac`. I ran the build again and confirmed that local install seemed to work as expected. (ie "ToggleAllDocks!! 🎉") While here, I also removed the last reference to `$local_arch`, because all other references to that were removed in #41392. /cc @osiewicz Release Notes: - N/A --------- Co-authored-by: Conrad Irwin <[email protected]>
ConradIrwin
added a commit
that referenced
this pull request
Oct 31, 2025
I just pulled and ran a local build via `script/bundle-mac -l -i` but found that the resulting bundle wasn't installed as expected. (me: "ToggleAllDocks!! Wait! Where is it?!") Looking into, it looks like the `-l` flag was removed in #41392, leaving the `$local_only` var orphaned, which then left the `-i/$local_install` flag unreachable. I suspect that this was unintentional, so this PR re-adds the `-l/$local_only` flag to `script/bundle-mac`. I ran the build again and confirmed that local install seemed to work as expected. (ie "ToggleAllDocks!! 🎉") While here, I also removed the last reference to `$local_arch`, because all other references to that were removed in #41392. /cc @osiewicz Release Notes: - N/A --------- Co-authored-by: Conrad Irwin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes: