windows: Remove null terminator from keyboard ID #41785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unnecessary, and it broke the `uses_altgr` function. Also add Slovenian layout as using AltGr.
cla-bot
bot
added
the
cla-signed
tidylogic
reviewed
Nov 3, 2025
Member
|
Looks good, thanks for the fix ^^ |
Contributor
Author
|
Thanks! @nia-e Not trying to tell you what to do, just signal boosting, if you have the capacity you should take a look at #41259 because it seems to properly solve the AltGr issue without hard-coding specific languages (and without the current problem of requesting the layout on every event). It also supposedly solves other issues as well. I'm not an expert in Windows input handling, so I can't give much input on it, but I think it's worth a look. |
Contributor
Author
|
@nia-e Oh, never mind, the creator of that PR is also a member of Zed :D |
P1n3appl3
pushed a commit
to bnjjj/zed
that referenced
this pull request
Nov 4, 2025
Closes zed-industries#41486, closes zed-industries#35862 It is unnecessary, and it broke the `uses_altgr` function. Also add Slovenian layout as using AltGr. This should fix: - zed-industries#40536 (comment) - zed-industries#41486 - zed-industries#35862 As the current strategy relies on manually adding layouts that have AltGr, it's brittle and not very elegant. It also has other issues (it requests the current layout on every kesytroke and mouse movement). **A potentially better and more comprehensive solution is at zed-industries#41259 This is just to fix the immediate issues while that gets reviewed. Release Notes: - windows: Fix AltGr handling on non-US layouts again.
tomatitito
pushed a commit
to tomatitito/zed
that referenced
this pull request
Nov 7, 2025
Closes zed-industries#41486, closes zed-industries#35862 It is unnecessary, and it broke the `uses_altgr` function. Also add Slovenian layout as using AltGr. This should fix: - zed-industries#40536 (comment) - zed-industries#41486 - zed-industries#35862 As the current strategy relies on manually adding layouts that have AltGr, it's brittle and not very elegant. It also has other issues (it requests the current layout on every kesytroke and mouse movement). **A potentially better and more comprehensive solution is at zed-industries#41259 This is just to fix the immediate issues while that gets reviewed. Release Notes: - windows: Fix AltGr handling on non-US layouts again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41486, closes #35862
It is unnecessary, and it broke the
uses_altgrfunction.Also add Slovenian layout as using AltGr.
This should fix:
As the current strategy relies on manually adding layouts that have AltGr, it's brittle and not very elegant. It also has other issues (it requests the current layout on every kesytroke and mouse movement).
A potentially better and more comprehensive solution is at #41259
This is just to fix the immediate issues while that gets reviewed.
Release Notes: