-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the Canonical Project Structure for Broker #390
Use the Canonical Project Structure for Broker #390
Conversation
3e3213b
to
66bf0df
Compare
For the Canonical Project Structure, see https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1204r0.html. With the new structure, we drop the `include` and `src` sub-directories and place the source files next to the header files under `libbroker`. Further, we place the unit tests next to the source file with `.test.cc` suffix. Standalone tools have been placed alongside `libbroker` to the project root, whereas system/integration tests as well as benchmarks remain under `tests`, but are organized more consistently.
66bf0df
to
3c64a31
Compare
@ckreibich most files have just been renamed. One notable exception is for the unit tests: I have dropped the manual There are no functional changes. However, I did find obviously obsolete stuff like There are several tests and benchmarks that we currently don't build (commented out in CMake). I'll check each of those individually as a followup to see what can be restored and what might be obsolete (or became superfluous, e.g., due to a new btest). |
@ckreibich any ETA on this? I'd really like to get this in before doing tackling other issues (like #391) to avoid conflicts. |
@@ -1,6 +1,6 @@ | |||
find_package(benchmark QUIET) | |||
|
|||
# add_subdirectory(cluster) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the rest of these benchmarks coming back later? I know there's an open issue for the cluster one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I plan to make a pass over them later. Some of them seem outdated, though. So probably not all of them will come back.
For the Canonical Project Structure, see
https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1204r0.html.
With the new structure, we drop the
include
andsrc
sub-directories and place the source files next to the header files underlibbroker
. Further, we place the unit tests next to the source file with.test.cc
suffix.Standalone tools have been placed alongside
libbroker
to the project root, whereas system/integration tests as well as benchmarks remain undertests
, but are organized more consistently.