Fix restore bug, and sort restoreable backups by mtime #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, the sorting doesn't work (got a dict where i didn't expect one) so I'll back that out and revisit later. The |
sort backups by file mtime Revert "sort backups by file mtime" This reverts commit 2b2137f.
joelbernstein
force-pushed
the
master
branch
from
a3f000c to
1c99232
Compare
|
This fixes #2 - please apply / discuss. |
|
Nonetheless, this does make me wonder whether you have actually tested the restore system at all? |
|
thanks for correction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @zeenlym
I have found and fixed a bug in the restore functionality. The way you were constructing the
2>/dev/nullshell redirection was not working, as it must be2>whereverand not (as you had)2 > wherever. Your command resulted in passing a '2' argument to7zrwhich caused it to try to extract a file called '2' which does not exist in the archive.I have also added some (not very well tested) code to sort the list of backups available to restore by file modification time, this makes it easier to select the correct one.Can you merge this into master and rebuild the docker image on docker hub please?