Skip to content

Fix #12074: Preserve container when opening View Page Source #12086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
R0h1tAnand wants to merge 1 commit into
base: dev
Choose a base branch
from
+11 −0
Open

Fix #12074: Preserve container when opening View Page Source #12086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/browser/components/tabbrowser/content/tabbrowser-js.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,17 @@ index 0eaca7a58e0026237b71b2ad515efe84d9e8c779..2ab8633d0378e5a25cf75c50b29d4689
);
}

+ if (
+ userContextId === undefined &&
+ aURI?.spec?.startsWith("view-source:") &&
+ this.selectedTab
+ ) {
+ const selectedUserContextId = this.selectedTab.getAttribute("usercontextid");
+ if (selectedUserContextId) {
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The truthiness check if (selectedUserContextId) will skip inheritance when the selected tab has usercontextid="0" (No Container), because the string "0" is falsy in JavaScript. This means view-source will not inherit "No Container" explicitly set on a tab, which may or may not be intentional. Consider using if (selectedUserContextId !== null) to handle the "0" case explicitly, or document why "No Container" should not be inherited.

Suggested change
+ if (selectedUserContextId) {
+ if (selectedUserContextId !== null) {

Copilot uses AI. Check for mistakes.
+ userContextId = parseInt(selectedUserContextId, 10);
+ }
+ }
+
+ let hasZenDefaultUserContextId = false;
+ let zenForcedWorkspaceId = undefined;
+ if (typeof gZenWorkspaces !== "undefined" && !_forZenEmptyTab) {
Expand Down