gh-8309: Fix moving essential tabs to new window - #14144
Conversation
dosubot
Bot
added
the
size:M
|
There seems to be git conflicts, could you please fix it? |
0e00aca to
6785236
Compare
dosubot
Bot
added
size:L
|
Whoops, yeah should be fixed now :) |
|
Hi, could you please fix the git issues again? Sorry about that. |
6785236 to
c9678e7
Compare
|
No worries. Should be ready to merge again. |
c9678e7 to
f6f4792
Compare
|
I fixed the conflicts again. Is there anything else you need from me to merge this @mr-cheffy ? |
mr-cheffy
left a comment
mr-cheffy
left a comment
There was a problem hiding this comment.
Why's there 2 different normalizeDuplicatedEssentialTab going on? What does each branch do
|
They were doing the same thing in the single-tab and multi-tab paths. I moved that into one shared helper and also made both paths wait for SSTabRestored before moving the duplicate. Added tests fr it too. |
7d8b82a to
a951ad5
Compare
dosubot
Bot
added
size:M
a951ad5 to
e7cdb4e
Compare
|
Since dev keeps moving and this PR has picked up conflicts a few times now, I’m going to hold off on rebasing again until you’re ready to take another look @mr-cheffy . |
2 participants
Fixes #8309.
updates the move-to-new-window behavior for Essential tabs. For normal user moves, keeps the original Essential tab in place and opens a regular copy in the new window.
I also added coverage for the related edge cases that came up while testing this path.