refactor: migrate to tailwind 4#684
Open
JosueGalRe wants to merge 10 commits intozen-browser:mainfrom
Open
Conversation
Raiden0456
reviewed
Jun 18, 2025
Member
Raiden0456
left a comment
Raiden0456
left a comment
There was a problem hiding this comment.
Have you checked all pages with <style> tags in them? although new approach looks ok, we have to be double check all the places
Member
Author
Most (I think all) of them were components and they look good, but feel free to do a side by side comparison |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note: per file/component style tag with @/apply tags can be done but could cause issues and will force tw to process stylesheets multiple times, because now to use @/apply you need to @/reference tw in the style tag you will use it, as per this, i have moved all classes into a single file, we can re arrange into other ways, but wouldn't recommend to use style tags again unless necessary.