Open
Conversation
ecoologic
reviewed
Aug 9, 2023
Contributor
There was a problem hiding this comment.
Hi @fulcanelly. Thank you for your contribution.
A couple of comments, but mainly, we can't approve any work that doesn't come with tests.
Could you write some unit tests for this?
Thanks again
|
|
||
| class TargetFailure < ReadResource | ||
| def target | ||
| @client.targets.to_a.find do |target| |
Contributor
There was a problem hiding this comment.
If you use .all in stead of to_a you should be able to reduce the number of calls in case of pagination.
| class TargetFailure < ReadResource | ||
| def target | ||
| @client.targets.to_a.find do |target| | ||
| target.title == self.target_name |
Contributor
There was a problem hiding this comment.
Given the match is done on title, I would suggest naming the method target_by_title. (?? not too sure).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://developer.zendesk.com/api-reference/ticketing/targets/target_failures/#show-target-failure