This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Security Advisory: json_decode() expects parameter 1 to be string, array given #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, that sounds like a configuration error on your side, or SecurityAdvisory version incompatibility. We'll need more info to investigate. |
|
@Thinkscape What kind of info are you expecting? |
|
Anything that will help :-) Try to create a reproduce scenario, ideally send a PR with a test that shows the problem. |
|
@Thinkscape OKey, it looks like this:
I hope it will be helpful :] |
|
Does that mean you're trying to run the check with invalid (empty, missing) advisories ? |
|
Do you mean the |
|
@Thinkscape Do you know how to solve this problem? |
|
The problem still exists. I'm using the latest version (dev-master 23998e7). Are you going to solve this problem? |
|
It looks like we could solve the issue as follows: $advisories = $this->securityChecker->check($this->lockFilePath, 'json');
if (is_string($advisories)) {
$advisories = @json_decode($advisories);
}
if (! is_array($advisories)) {
return new Warning('Could not parse response from security advisory service.');
}
/* ... continue on ... */I'll create a PR for this for you to test, @kniziol . |
- Ensures that we can use either native PHP code returned by the security checker, or JSON.
|
@kniziol you can test this pull request. :) |
|
@weierophinney thanks. It looks good and the problem is gone. Details:
|
|
Merged, and tagged 1.0.3 so this will be picked up in stable versions. |
|
Thx. On Monday, August 11, 2014, weierophinney [email protected] wrote:
[email protected] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
monitor:healthWARNING Security Advisory: json_decode() expects parameter 1 to be string, array givenSolution:
Remove
$advisories = @json_decode($advisories);inZendDiagnostics\Check\SecurityAdvisoryand the warning is gone.