-
Notifications
You must be signed in to change notification settings - Fork 12
Use PSR-11 Container Interface #37
Use PSR-11 Container Interface #37
Conversation
@xtreamwayz this looks good (so far) but I suggest waiting on merging this until There are quite a number of references to it in |
I went ahead and submitted a PR to both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be marked as BC Break, because we change type of exception. Maybe type hint in factories is not a big issue, don't think so that somebody extends these factories and override __invoke
method. But anyway... it's still possible.
@@ -19,7 +19,8 @@ | |||
}, | |||
"require": { | |||
"php": "^5.6 || ^7.0", | |||
"container-interop/container-interop": "^1.2", | |||
"container-interop/container-interop": "^1.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need above line. We are not using this library here anymore.
We need of course conflict
entry, as it is now below.
|
||
class MissingHelperException extends DomainException implements | ||
ContainerException, | ||
ContainerExceptionInterface, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it here BC Break? If somebody catch exception on ContainerException
it will stop work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they were catching Interop\Container\Exception\ContainerException
, however, and the container in use implements PSR-11 only, then there's breakage.
At this point this is starting to look really good. I do think we need to support PSR-11 properly, there are some other comments that might be necessary to look at prior. My approval is strictly on the code and the implements. |
Use PSR-11 Container Interface Conflicts: composer.lock
Thanks, @xtreamwayz! |
container-interop can't be removed completely...
ZendViewRendererFactoryTest
has tests forZend\ServiceManager\AbstractPluginManager
, which is not updated yet.