This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Add zend-servicemanager as a required dependency #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After being bitten by the bug in zendframework#119, where I couldn't use zend-inputfilter without zend-servicemanager, I'm proposing this PR, which makes zend-servicemanager a required dependency. I can't claim to understand all the reasoning for not doing so to date, but based on this experience, it makes sense to make the change.
|
The original idea was that you could use the As such, I'm marking this as a bugfix, and will merge it for an upcoming 2.8.1 release. |
weierophinney
added a commit
that referenced
this pull request
Jan 22, 2018
…datory-dependency Add zend-servicemanager as a required dependency
weierophinney
added a commit
that referenced
this pull request
Jan 22, 2018
|
Thanks, @settermjd! |
|
Thanks for sharing the extra background information, @weierophinney. It helps me understand it in a greater context. And thanks for merging the PR too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a narrative description of what you are trying to accomplish:
After being bitten by the bug in #119, where I couldn't use
zend-inputfilterwithoutzend-servicemanager, I'm proposing this PR, which makeszend-servicemanagera required dependency ofzend-inputfilter. I can't claim to understand all the reasoning for not doing so to date (I'm happy to defer if necessary), but based on this experience it makes sense to make the change.The above three questions are answered in #119 (comment).