-
Notifications
You must be signed in to change notification settings - Fork 110
Add option novalidatecert to connect() #246
Conversation
Change of method signature is BC Break. Can we implement it the other way without changing the method signature? |
This is why I added this as an optional parameter, which is indeed BC because the params are an array. |
We can add it to parameter in the constructor, set it to property and use in connect inside. There are multiple options to implement it without BC break, we just need to choose the best one, which will be the best for the future major release. BTW. Thanks for creating this PR :) 👍 |
I see, thanks! You can close this PR, I will try to implement it like this and create a new PR. |
@abulhol no need for new PR, you can continue on this. Thanks again :) |
@abulhol Also, remember to target |
I have created a PR to the |
@abulhol |
This commit is a proposed fix for the following issue:
#84
It introduces an optional parameter
novalidatecert
both for POP3 and IMAP, which makes it possible to connect to mail servers with self-signed certificates, e.g. for development purposes.