Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Conversation

@glensc
Copy link
Contributor

@glensc glensc commented May 18, 2017

this does solve GenericHeader::toString + Header\AbstractAddressList::fromString problem
reported here: zendframework/zend-mail#146

this does solve GenericHeader::toString + Header\AbstractAddressList::fromString problem
reported here: zendframework/zend-mail#146
@weierophinney
Copy link
Member

Interestingly, this causes existing expectations to fail; please review the travis logs. If the existing tests are now incorrect (as the proposed change would encode commas), then please update the unit tests. It the existing tests are correct, then your patch needs updating.

Thanks!

@glensc
Copy link
Contributor Author

glensc commented Jun 8, 2017

yes, obviously it changes encoding result.

if you accept the change, i can update tests to use updated encoding result.
see details in referred PR zendframework/zend-mail#146

there's only one test failing:

1) ZendTest\Mime\MimeTest::testEncodeMailHeaderQuotedPrintable with data set #3 ('Alle meine Entchen schwimmen ... Höh!', 'UTF-8', '=?UTF-8?Q?Alle=20meine=20Entc...B6h!?=')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'=?UTF-8?Q?Alle=20meine=20Entchen=20schwimmen=20in=20dem=20See,=20?=
- =?UTF-8?Q?schwimmen=20in=20dem=20See,=20K=C3=B6pfchen=20in=20das=20?=
- =?UTF-8?Q?Wasser,=20Schw=C3=A4nzchen=20in=20die=20H=C3=B6h!?='
+'=?UTF-8?Q?Alle=20meine=20Entchen=20schwimmen=20in=20dem=20See=2C=20?=
+ =?UTF-8?Q?schwimmen=20in=20dem=20See=2C=20K=C3=B6pfchen=20in=20das=20?=
+ =?UTF-8?Q?Wasser=2C=20Schw=C3=A4nzchen=20in=20die=20H=C3=B6h!?='

updating it, is trivial, so done

@glensc
Copy link
Contributor Author

glensc commented Jun 12, 2017

@weierophinney the requested changes are made!

glensc added a commit to glensc/eventum that referenced this pull request Jul 20, 2017
got totally drowned in zend/mail, zend/mime, and eventum bugs

zendframework/zend-mime#26
zendframework/zend-mail#146
@weierophinney weierophinney merged commit f6bbea2 into zendframework:master Nov 28, 2017
weierophinney added a commit that referenced this pull request Nov 28, 2017
weierophinney added a commit that referenced this pull request Nov 28, 2017
weierophinney added a commit that referenced this pull request Nov 28, 2017
weierophinney added a commit that referenced this pull request Nov 28, 2017
@weierophinney
Copy link
Member

Thanks, @glensc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants