This repository was archived by the owner on Jan 30, 2020. It is now read-only.
-
Couldn't load subscription status.
- Fork 36
Mime: encode comma #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this does solve GenericHeader::toString + Header\AbstractAddressList::fromString problem reported here: zendframework/zend-mail#146
|
Interestingly, this causes existing expectations to fail; please review the travis logs. If the existing tests are now incorrect (as the proposed change would encode commas), then please update the unit tests. It the existing tests are correct, then your patch needs updating. Thanks! |
|
yes, obviously it changes encoding result. if you accept the change, i can update tests to use updated encoding result. there's only one test failing: updating it, is trivial, so done |
|
@weierophinney the requested changes are made! |
glensc
added a commit
to glensc/eventum
that referenced
this pull request
Jul 20, 2017
got totally drowned in zend/mail, zend/mime, and eventum bugs zendframework/zend-mime#26 zendframework/zend-mail#146
weierophinney
added a commit
that referenced
this pull request
Nov 28, 2017
weierophinney
added a commit
that referenced
this pull request
Nov 28, 2017
|
Thanks, @glensc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this does solve GenericHeader::toString + Header\AbstractAddressList::fromString problem
reported here: zendframework/zend-mail#146