This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Fixes #99 - Missing documentation for Escape view helpers #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public $headline = '<h1>Foo</h1>'; | ||
| }; | ||
|
|
||
| var_dump($this->escapeHtml($object, Zend\View\Helper\EscapeHtml::RECURSE_OBJECT)); |
There was a problem hiding this comment.
is the 2nd param required here?
I assume the same result we get without it.
There was a problem hiding this comment.
Without the second parameter an exception is thrown:
zend-view/src/Helper/Escaper/AbstractHelper.php
Lines 72 to 74 in b486187
doc/book/helpers/escape.md
Outdated
|
|
||
| The following helpers can **escape output in view scripts and defend from XSS | ||
| and related vulnerabilities**. To escape different contexts of a HTML document, | ||
| zend-view provides 5 helpers: |
There was a problem hiding this comment.
I don't like fixed numbers, it's a very big chance that it will be not update if the number of escapers change.
Maybe better "provides the following helpers:" ?
michalbundyra
approved these changes
Oct 10, 2019
michalbundyra
added a commit
that referenced
this pull request
Oct 10, 2019
Fixes #99 - Missing documentation for Escape view helpers
|
Thanks, @froschdesign! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.