Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Update head-script.md #196

Merged

Conversation

rcapile
Copy link
Contributor

@rcapile rcapile commented Oct 23, 2019

  • Is this related to documentation?
    typo: Missing > at the example

Missing `>` at example
@michalbundyra
Copy link
Member

Thanks, @rcapile!

michalbundyra added a commit that referenced this pull request Oct 23, 2019
@michalbundyra michalbundyra merged commit 1a7d645 into zendframework:master Oct 23, 2019
michalbundyra added a commit that referenced this pull request Oct 23, 2019
@rcapile
Copy link
Contributor Author

rcapile commented Oct 23, 2019

sorry I made things worse.

The documentation uses > to create a quote. It works fine in GitHub, but breaks completely at zf doc site.

https://docs.zendframework.com/zend-view/helpers/head-script/#headscript

I looking up if this a bug from mkdocs or there is something missing

@rcapile rcapile deleted the hotfix/docs/helpers/head-script branch October 23, 2019 17:34
@michalbundyra
Copy link
Member

ping @froschdesign

what do you think about it?

@rcapile
Copy link
Contributor Author

rcapile commented Oct 23, 2019

just FYI I tried changing < to &lt; it works with mkdocs (with default layout, not with zf layout) but it breaks at github.

it seems that fenced code blocks inside a quote does not work well with mkdocs

@froschdesign
Copy link
Member

@rcapile

it seems that fenced code blocks inside a quote does not work well with mkdocs

This is not a problem of MkDocs: https://python-markdown.github.io/extensions/fenced_code_blocks/#syntax

@rcapile
Copy link
Contributor Author

rcapile commented Oct 23, 2019

I just find out this is a known bug with no fix in sight

Python-Markdown/markdown#53

@froschdesign
Copy link
Member

@rcapile

I just find out this is a known bug with no fix in sight

Unfortunately, it's not supported and not a bug.

@michalbundyra
Copy link
Member

@froschdesign do you think we can solve it somehow by separate script in our template?
As we are doing couple other things - table_fix_pipes.php, table_responsive.php, etc...

@froschdesign
Copy link
Member

@webimpress
As workaround we can replace the backticks with the standard Markdown for code blocks (4 spaces). Then we can rewrite the HTML from:

<pre class="codehilite line-numbers"><code></code></pre>

to

<pre class="codehilite line-numbers language-php"><code></code></pre>

Then the code can be read but without colour.

@michalbundyra
Copy link
Member

@rcapile all is working fine now :) We have made some changes in the template and fenced code blocks are working correctly. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants