Adding Git Style Messages #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like git when a command that can take a note as an agrument does note include the note the user is prompted with their default editior to add or edit the existing note depending on the command used. If start is used the note is defaulted to blank if left blank no note is set. If stop the existing note is used to populate the editor. Changes to this note will overwrite the existing note, not append
|
Thanks so much for the patch! I'm busy right now but I'll get to this soon. |
zenhob
reviewed
Feb 6, 2017
| @@ -14,6 +14,7 @@ task :clean do | |||
| end | |||
|
|
|||
| require 'rake/testtask' | |||
| ENV['EDITOR'] = '' | |||
There was a problem hiding this comment.
Keep in mind that this sets EDITOR globally for the Rakefile, because it's executed at the top level. This is probably not what is intended.
zenhob
reviewed
Feb 6, 2017
| @@ -111,9 +112,24 @@ def start *args | |||
| if task.nil? | |||
| fail "Unknown task alias, try one of the following: ", aliases.join(', ') | |||
| end | |||
| note = args.join(' ') | |||
There was a problem hiding this comment.
This is good functionality but it repeats a lot of code. You should consider creating a helper method of some kind that does most of the heavy lifting, and then your repeated pattern is just a method call.
|
This is a great idea, but this patch needs some work. I've offered a few comments, but since it's been literally years I understand if you're over it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like git when a command that can take a note as an argument does not
contain a note as an argument the user is prompted with their default editor to add
or edit the existing note depending on the command used.
If start is used the note is defaulted to blank if left blank no note is
set.
If stop the existing note is used to populate the editor. Changes to
this note will overwrite the existing note, not append.
If a note is included in either start or stop the command behave as normal appending the note
argument to the entry.