[postal-savings-rs] rewrite for new banking platform

src/plugins/postal-savings-rs/converters.ts

@@ -1,81 +1,96 @@
-import { AccountType, Transaction, Account } from '../../types/zenmoney'
-import { AccountDetails } from './models'
-import moment from 'moment'
+import { AccountOrCard, AccountType, ExtendedTransaction } from '../../types/zenmoney'
+import { AccountInfo, AccountTransaction } from './models'
 
-function accountDetailsToId (account: AccountDetails): string {
-  return `${account.id}${account.type}`
+export function convertAccounts (apiAccounts: AccountInfo[]): AccountOrCard[] {
+  return apiAccounts.map(apiAccount => {
+    return {
+      id: apiAccount.id,
+      type: AccountType.ccard,
+      title: apiAccount.name,
+      instrument: apiAccount.currency,
+      balance: apiAccount.balance,
+      available: apiAccount.balance,
+      creditLimit: 0,
+      syncIds: [apiAccount.id]
+    }
+  })
 }
 
-function parseSum (s: string): number {
-  return parseFloat(s.replace(' ', '').replace('.', '').replace(',', '.'))
-}
-
-function descriptionCleanup (s: string): string {
-  const substrToRemove = ['ISPLATA VISA', 'UPLATA VISA']
+export function convertTransaction (accountTransaction: AccountTransaction, account: AccountInfo, hold = false): ExtendedTransaction | null {
+  accountTransaction.currency = accountTransaction.currency === undefined
+    ? 'RSD'
+    : accountTransaction.currency
 
-  const decode = function (str: string): string {
-    return str.replace(/&#(\d+);/g, function (match: string, dec): string {
-      return String.fromCharCode(dec)
-    })
+  if (accountTransaction.amount === 0) {
+    return null
+  }
+  let invoice = {
+    sum: accountTransaction.amount,
+    instrument: accountTransaction.currency
+  }
+  const match = accountTransaction.description.match(/^([\d.]+)\s(\w{3})/)
+  if (match != null) {
+    invoice = {
+      sum: accountTransaction.amount < 0 ? -parseFloat(match[1]) : parseFloat(match[1]),
+      instrument: match[2]
+    }
   }
-  const decodedStr = decode(s).replace('&nbsp;', ' ').trim()
-  const strWithoutGarbage = substrToRemove.reduce((acc, s) => acc.replace(s, ''), decodedStr).trim()
 
-  return strWithoutGarbage.length > 0 ? strWithoutGarbage : decodedStr
+  const transaction: ExtendedTransaction = {
+    hold,
+    date: accountTransaction.date,
+    movements: [
+      {
+        id: accountTransaction.id,
+        account: { id: account.id },
+        sum: invoice?.instrument !== account.currency ? null : accountTransaction.amount,
+        fee: 0,
+        invoice: invoice?.instrument === account.currency ? null : invoice
+      }
+    ],
+    merchant: null,
+    comment: accountTransaction.description !== '' && (match == null) ? accountTransaction.description : null
+  };
+  [
+    parseCashTransfer,
+    parsePayeeAndComment
+  ].some(parser => parser(transaction, accountTransaction, account, invoice))
+  return transaction
 }
 
-export function convertAccount (account: AccountDetails, data: string): Account {
-  const id = accountDetailsToId(account)
-
-  const descriptionPattern = /<td>([\w\s]+):<\/td>\s+<td>\d+<\/td>/
-  const description = descriptionPattern.exec(data)
-
-  const balancePattern = /<td>Balance for currency (\w+) \d+:<\/td>\s+<td>([\d.,]+)\s+<\/table>/
-  const balance = balancePattern.exec(data)
-
-  return {
-    id,
-    type: AccountType.ccard,
-    title: (description != null) ? description[1] : id,
-    instrument: (balance != null) ? balance[1] : 'RSD',
-    balance: (balance != null) ? parseSum(balance[2]) : 0,
-    creditLimit: 0,
-    syncIds: [id]
+function parseCashTransfer (transaction: ExtendedTransaction, accountTransaction: AccountTransaction, account: AccountInfo, invoice: { sum: number, instrument: string }): boolean {
+  if ([
+    /ATM/,
+    /Gotovinska/i
+  ].some(regexp => regexp.test(accountTransaction.address))) {
+    transaction.movements.push({
+      id: null,
+      account: {
+        company: null,
+        instrument: invoice.instrument,
+        syncIds: null,
+        type: AccountType.cash
+      },
+      invoice: null,
+      sum: -invoice.sum,
+      fee: 0
+    })
   }
+  return false
 }
 
-export function convertTransactions (account: AccountDetails, data: string): Transaction[] {
-  const transactions: Transaction[] = []
-
-  const regexp = /<tr>\s+<td[^>]+>([\d.]+)<\/td>\s+<td[^>]+>([^<]+)<\/td>\s+<td[^>]+>(\w+)\s\d+<\/td>\s+<td[^>]+>\+?([-\d,.]+)<\/td>/g
-  const matches = data.matchAll(regexp)
-
-  for (const t of matches) {
-    const [, date, desc, , sum] = t
-
-    transactions.push({
-      hold: false,
-      date: moment(date, 'DD.MM.YYYY').toDate(),
-      movements: [
-        {
-          id: null,
-          account: { id: accountDetailsToId(account) },
-          // TODO: parse from /kartizv.jsp
-          invoice: null,
-          sum: parseSum(sum),
-          fee: 0
-        }
-      ],
-      merchant: desc != null
-        ? {
-            fullTitle: descriptionCleanup(desc),
-            mcc: null,
-            location: null
-          }
-        : null,
-      comment: null
-    })
+function parsePayeeAndComment (transaction: ExtendedTransaction, accountTransaction: AccountTransaction, account: AccountInfo, invoice: { sum: number, instrument: string }): boolean {
+  transaction.merchant = {
+    fullTitle: accountTransaction.address,
+    mcc: null,
+    location: null
   }
-
-  return transactions.reverse()
+  if ([
+    /Uplata/i,
+    /Gotovinska/i
+  ].some(regex => regex.test(accountTransaction.address))) {
+    transaction.merchant = null
+    transaction.comment = accountTransaction.address
+  }
+  return false
 }